[Lldb-commits] [lldb] [LLDB] Warn about truncated DWARF section names on Windows (PR #145175)

[David Spickett via lldb-commits]

================
@@ -1036,12 +1036,18 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) {
     m_sections_up->AddSection(header_sp);
     unified_section_list.AddSection(header_sp);
 
+    std::vector<llvm::StringRef> truncated_dwarf_sections;
     const uint32_t nsects = m_sect_headers.size();
     for (uint32_t idx = 0; idx < nsects; ++idx) {
       llvm::StringRef sect_name = GetSectionName(m_sect_headers[idx]);
       ConstString const_sect_name(sect_name);
       SectionType section_type = GetSectionType(sect_name, m_sect_headers[idx]);
 
+      // Detect unknown sections matching ^\.debug_[a-z]$
+      if (section_type == eSectionTypeOther && sect_name.size() == 8 &&
----------------
DavidSpickett wrote:

> For longer names, the linker has to write the section name into the string table and set the name in the section header to /n where n is the offset in the string table.

Besides the point of this PR, but is there any information about whether link.exe does this too, or if it's just an escape route for third parties?

Though even if it did this, our parser would have to be updated to parse it too. I could understand a hypothetical link.exe option being off by default for tool compatibility reasons.

https://github.com/llvm/llvm-project/pull/145175