[Lldb-commits] [lldb] [lldb] upgrade HandleFrameFormatVariable callees to llvm::Expected (PR #144731)

[Michael Buch via lldb-commits]

================
@@ -74,24 +74,48 @@ struct DemangledNameInfo {
     return BasenameRange.second > BasenameRange.first;
   }
 
+  /// Returns \c true if `BasenameRange` is empty.
+  bool isBasenameEmpty() const {
+    return BasenameRange.first == BasenameRange.second;
----------------
Michael137 wrote:

Thanks for adjusting. Mostly looks good now

Though I don't think `hasBasename` should allow for `start == end`. That's the one range that all `DemangledInfo` objects need to have to be considered valid. Could we keep that as `end > start`? I don't think that should break anything

https://github.com/llvm/llvm-project/pull/144731