[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

[James Y Knight via lldb-commits]

jyknight wrote:

> Thanks for the concrete example! [..]

I just wanted to thank you (a bit late) for the explanation above, it was really helpful!

> FWIW I'd like to get rid of the reference count of DiagnosticsEngine too, and make the lifetimes stricter and more explicit, but that's a lower priority compared to the DiagnosticOptions refactor for me.

I do hope that will happen someday, because that does seem to be a key part of the confusion here. But I totally understand about the priority.

https://github.com/llvm/llvm-project/pull/139584