[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 20 07:34:27 PDT 2025


================
@@ -16,6 +16,16 @@
 
 namespace lldb_private {
 
+class ARMSingleStepBreakpointLocationsPredictor
+    : public SingleStepBreakpointLocationsPredictor {
+public:
+  ARMSingleStepBreakpointLocationsPredictor(
+      std::unique_ptr<EmulateInstruction> emulator_up)
+      : SingleStepBreakpointLocationsPredictor{std::move(emulator_up)} {}
----------------
DavidSpickett wrote:

```
class SingleStepBreakpointLocationsPredictor {
public:
  SingleStepBreakpointLocationsPredictor(
      std::unique_ptr<EmulateInstruction> emulator_up)
      : m_emulator_up{std::move(emulator_up)} {}
```
Seems like you just pass on to this. Can this sub-class not just use the base class constructor?

https://github.com/llvm/llvm-project/pull/127505


More information about the lldb-commits mailing list