[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

[Pavel Labath via lldb-commits]

================
@@ -239,122 +240,39 @@ VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) {
 
 bool lldb_private::formatters::LibStdcppStringSummaryProvider(
     ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) {
-  const bool scalar_is_load_addr = true;
-  auto [addr_of_string, addr_type] =
-      valobj.IsPointerOrReferenceType()
-          ? valobj.GetPointerValue()
-          : valobj.GetAddressOf(scalar_is_load_addr);
-  if (addr_of_string != LLDB_INVALID_ADDRESS) {
-    switch (addr_type) {
-    case eAddressTypeLoad: {
-      ProcessSP process_sp(valobj.GetProcessSP());
-      if (!process_sp)
-        return false;
-
-      StringPrinter::ReadStringAndDumpToStreamOptions options(valobj);
-      Status error;
-      lldb::addr_t addr_of_data =
-          process_sp->ReadPointerFromMemory(addr_of_string, error);
-      if (error.Fail() || addr_of_data == 0 ||
-          addr_of_data == LLDB_INVALID_ADDRESS)
-        return false;
-      options.SetLocation(addr_of_data);
-      options.SetTargetSP(valobj.GetTargetSP());
-      options.SetStream(&stream);
-      options.SetNeedsZeroTermination(false);
-      options.SetBinaryZeroIsTerminator(true);
-      lldb::addr_t size_of_data = process_sp->ReadPointerFromMemory(
-          addr_of_string + process_sp->GetAddressByteSize(), error);
-      if (error.Fail())
-        return false;
-      options.SetSourceSize(size_of_data);
-      options.SetHasSourceSize(true);
-
-      if (!StringPrinter::ReadStringAndDumpToStream<
-              StringPrinter::StringElementType::UTF8>(options)) {
-        stream.Printf("Summary Unavailable");
-        return true;
-      } else
-        return true;
-    } break;
-    case eAddressTypeHost:
-      break;
-    case eAddressTypeInvalid:
-    case eAddressTypeFile:
-      break;
-    }
-  }
-  return false;
+  ValueObjectSP dataplus = valobj.GetChildMemberWithName("_M_dataplus");
+  if (!dataplus)
+    return false;
+  ValueObjectSP ptr = dataplus->GetChildMemberWithName("_M_p");
+  if (!ptr)
+    return false;
+
+  Address valobj_addr = ptr->GetPointerValue().address;
+  if (!valobj_addr.IsValid())
+    return false;
+
+  StringPrinter::ReadStringAndDumpToStreamOptions printer_opts(valobj);
+  printer_opts.SetLocation(valobj_addr);
+  printer_opts.SetTargetSP(valobj.GetTargetSP());
+  printer_opts.SetStream(&stream);
+
+  if (!StringPrinter::ReadStringAndDumpToStream<
+          StringPrinter::StringElementType::ASCII>(printer_opts))
+    stream.Printf("Summary Unavailable");
----------------
labath wrote:

Could this be something like `stream << ptr->GetSummaryAsCString()` ? I think that's more-or-less how the string summaries work...

https://github.com/llvm/llvm-project/pull/143177