[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

[Ebuka Ezike via lldb-commits]

da-viper wrote:

>What's the full help look like now? I wonder where this "Values: " comes from. Just want to make sure it's not leftover from a previous version of this PR where we called the names "values" in the error message.

The values come from the plugin help, this is what it looks like now.

```
(lldb) help process save-core
Save the current process as a core file using an appropriate file type.

Syntax: process save-core [-s corefile-style -p plugin-name] FILE

Command Options Usage:
  process save-core [-p[<plugin>]] [-s <corefile-style>] <path>

       -p[<plugin>] ( --plugin-name=[<plugin>] )
            Specify a plugin name to create the core file. This allows core files to be saved in different formats.
            Values: mach-o | minidump | pe-coff

       -s <corefile-style> ( --style <corefile-style> )
            Request a specific style of corefile to be saved.
            Values: full | modified-memory | stack
     
     This command takes options and free-form arguments.  If your arguments resemble option specifiers (i.e., they start with a - or --), you must use ' -- ' between the end of the
     command options and the beginning of the arguments.
```

https://github.com/llvm/llvm-project/pull/143126