[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)
via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 18 17:52:01 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r HEAD~1...HEAD lldb/test/API/python_api/find_in_memory/TestFindInMemory.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- TestFindInMemory.py 2025-06-18 23:49:12.000000 +0000
+++ TestFindInMemory.py 2025-06-19 00:51:36.148357 +0000
@@ -165,21 +165,32 @@
try:
for region in info_list:
collected_info.append(region)
except Exception:
self.fail("SBMemoryRegionInfoList is not iterable")
-
+
self.assertTrue(len(collected_info) >= 2, "Need at least 2 items")
- self.assertEqual(len(collected_info), info_list.GetSize(), "Should have collected all items")
+ self.assertEqual(
+ len(collected_info), info_list.GetSize(), "Should have collected all items"
+ )
for i in range(len(collected_info)):
region = lldb.SBMemoryRegionInfo()
info_list.GetMemoryRegionAtIndex(i, region)
-
- self.assertEqual(collected_info[i].GetRegionBase(), region.GetRegionBase(),
- f"items {i}: iterator data should match index access data")
- self.assertEqual(collected_info[i].GetRegionEnd(), region.GetRegionEnd(),
- f"items {i}: iterator data should match index access data")
-
+
+ self.assertEqual(
+ collected_info[i].GetRegionBase(),
+ region.GetRegionBase(),
+ f"items {i}: iterator data should match index access data",
+ )
+ self.assertEqual(
+ collected_info[i].GetRegionEnd(),
+ region.GetRegionEnd(),
+ f"items {i}: iterator data should match index access data",
+ )
+
if len(collected_info) >= 2:
- self.assertNotEqual(collected_info[0].GetRegionBase(), collected_info[1].GetRegionBase(),
- "Different items should have different base addresses")
+ self.assertNotEqual(
+ collected_info[0].GetRegionBase(),
+ collected_info[1].GetRegionBase(),
+ "Different items should have different base addresses",
+ )
``````````
</details>
https://github.com/llvm/llvm-project/pull/144815
More information about the lldb-commits
mailing list