[Lldb-commits] [lldb] [lldb] move XcodeSDK's sysroot into a separate class (PR #144396)

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 17 10:02:26 PDT 2025


================
@@ -982,7 +982,7 @@ lldb::LanguageType SymbolFileDWARF::ParseLanguage(CompileUnit &comp_unit) {
     return eLanguageTypeUnknown;
 }
 
-XcodeSDK SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) {
+XcodeSDKPath SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) {
----------------
adrian-prantl wrote:

Thinking out aloud: I was just going to write: "wouldn't it be better if this function returned an abstract SDK specification?" but then I realized that this is the point where we can read an absolute oath to the sysroot out of DWARF, so it needs to be am absolute path.

https://github.com/llvm/llvm-project/pull/144396


More information about the lldb-commits mailing list