[Lldb-commits] [lldb] [lldb-dap] Use protocol types for ReadMemory request (PR #144552)

[John Harrison via lldb-commits]

================
@@ -742,6 +742,42 @@ bool fromJSON(const llvm::json::Value &, DisassembledInstruction &,
               llvm::json::Path);
 llvm::json::Value toJSON(const DisassembledInstruction &);
 
+/// Arguments for `readMemory` request.
+struct ReadMemoryArguments {
----------------
ashgti wrote:

Can you move this to the https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h file instead? I've been trying to keep the files with:

ProtocolBase.{h,cpp} containing the 'Base Protocol' section from https://microsoft.github.io/debug-adapter-protocol/specification
ProtocolEvents.{h,cpp} containing the 'Events' section
ProtocolRequests.{h,cpp} containing the 'Requests' section
ProtocolTypes.{h,cpp} containing the 'Types' section.


https://github.com/llvm/llvm-project/pull/144552