[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

[Jonas Devlieghere via lldb-commits]

================
@@ -46,21 +46,27 @@ static bool ShouldDisplayAssemblySource(
   return false;
 }
 
-static protocol::Source CreateAssemblySource(const lldb::SBTarget &target,
-                                             lldb::SBAddress address) {
-  protocol::Source source;
+std::optional<protocol::Source> CreateAssemblySource(
+    const lldb::SBTarget &target, lldb::SBAddress address,
+    llvm::function_ref<int32_t(lldb::addr_t)> create_reference) {
----------------
JDevlieghere wrote:

I think a callback is a sign that this isn't the right layering. Why not move this into DAP? That would match what we do for variables and variable references (though unlike `Variables`, we probably don't need a separate class for this)

https://github.com/llvm/llvm-project/pull/144364