[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

[John Harrison via lldb-commits]

================
@@ -582,6 +582,28 @@ llvm::json::Value toJSON(const SteppingGranularity &SG) {
   llvm_unreachable("unhandled stepping granularity.");
 }
 
+bool fromJSON(const json::Value &Params, StepInTarget &SIT, json::Path P) {
+  json::ObjectMapper O(Params, P);
+  return O && O.map("id", SIT.id) && O.map("label", SIT.label) &&
+         O.map("line", SIT.line) && O.map("column", SIT.column) &&
+         O.map("endLine", SIT.endLine) && O.map("endColumn", SIT.endColumn);
----------------
ashgti wrote:

I think `line`, `column`, `endLine`, `endColumn` are all optional in the spec, so these should be `mapOptional` otherwise you'll get an error if they're not specified.

https://github.com/llvm/llvm-project/pull/144072