[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

John Harrison via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 11 10:12:10 PDT 2025


================
@@ -105,6 +105,21 @@ protocol::Source CreateSource(lldb::SBAddress address, lldb::SBTarget &target) {
   return CreateSource(line_entry.GetFileSpec());
 }
 
+protocol::Source CreateSource(lldb::SBFrame frame) {
+  if (!frame.IsValid())
+    return {};
----------------
ashgti wrote:

I think we should make this function return an `std::optional<protocol::Source>` as I think this should only be set if the source is valid. The source should have at least `path` and/or `sourceReference` set.

https://github.com/llvm/llvm-project/pull/143644


More information about the lldb-commits mailing list