[Lldb-commits] [lldb] [lldb/aarch64] Fix PC register info augmentation (PR #143499)

[Pavel Labath via lldb-commits]

labath wrote:

> I thought we augmented the target.xml from the remote gdb stub via `ABI::AugmentRegisterInfo` -- adding eh_frame/dwarf register numbers that were not supplied by the stub, for instance -- but looking at AArch64 & x86, it looks like it's just adding the slice registers like w0 / x0 and eip / rip to the registers provided. 

No, it's doing both. You see the slice registers because that's completely architecture specific. The register numbers are being added in the base class (MCBasedABI::AugmentRegisterInfo), which calls into this function (ABIAArch64::GetEHAndDWARFNums)

https://github.com/llvm/llvm-project/pull/143499