[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

[David Spickett via lldb-commits]

================
@@ -22,8 +22,26 @@ Status SaveCoreOptions::SetPluginName(const char *name) {
   }
 
   if (!PluginManager::IsRegisteredObjectFilePluginName(name)) {
----------------
DavidSpickett wrote:

In other words:
if (!PluginManager::IsRegisteredObjectFilePluginName(name)) {

Is checking a different list of names than:
PluginManager::GetSaveCorePluginNames();

Will print.

So a user could use a valid plugin name, for a plugin that doesn't happen to support core files. Then read the error message later and see that name doesn't even appear even though the command accepted it.

https://github.com/llvm/llvm-project/pull/143126