[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

[David Spickett via lldb-commits]

================
@@ -22,8 +22,19 @@ Status SaveCoreOptions::SetPluginName(const char *name) {
   }
 
   if (!PluginManager::IsRegisteredObjectFilePluginName(name)) {
-    return Status::FromErrorStringWithFormat(
-        "plugin name '%s' is not a valid ObjectFile plugin name", name);
+    StreamString stream;
+    stream.Printf("plugin name '%s' is not a valid ObjectFile plugin name.",
+                  name);
+
+    llvm::SmallVector<llvm::StringRef> plugin_names =
+        PluginManager::GetSaveCorePluginNames();
+    if (!plugin_names.empty()) {
+      stream.PutCString(" Valid values are: ");
----------------
DavidSpickett wrote:

Either refer to the names as names, or as values, not a mix of the two. I suggest using "name" in all cases.

https://github.com/llvm/llvm-project/pull/143126