[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

[via lldb-commits]

royitaqi wrote:

> > > Could we test this in `TestSimulatorPlatform.py`?
> > 
> > @JDevlieghere Thanks for pointer. It seems the tests in that file are all **skipped** because of this bug number: `rdar://76995109`.
> > E.g.
> > ```
> > UNSUPPORTED: LLDB (/Users/royshi/public_llvm/build/bin/clang-arm64) :: test_ios (TestSimulatorPlatform.TestSimulatorPlatformLaunching) (skipping unconditionally [rdar://76995109])
> > ```
> > 
> > Did a bit internet search and couldn't find how to find more info about this bug or why these tests are all skipped. Not sure if I should un-skip them.
> 
> Ha, that's my radar, and it's no longer relevant. I bisected an issue with the test suite to that particular test, but the last comment says that it wasn't the culprit after all, so there's no reason it should still be disabled.

Hi @JDevlieghere,

I don't think the test file was very happy when I removed that skip statement (`@skipIf(bugnumber="rdar://76995109")`). 4 tests coudln't build and 1 had assertion error about a mach-o load command (the other 7 skipped for other reasons). See full result: https://pastebin.com/Ka7KKdkC.

When you have the time, I wonder if you could kindly try on your side and see if they work for you.

FWIW I'm using the following command to build and test:
```
ls ~/public_llvm/llvm-project
cd ~/public_llvm/build
cmake -G Ninja -DLLVM_ENABLE_PROJECTS="clang;lldb" -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" ~/public_llvm/llvm-project/llvm
ninja lldb-api-test-deps
bin/llvm-lit -sv ../llvm-project/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py
```


https://github.com/llvm/llvm-project/pull/139174