[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

[via lldb-commits]

royitaqi wrote:

Thanks for the great discussion, @JDevlieghere and @labath. I appreciate it and am learning a lot by reading through it.

Re. CMakery and document, sorry that I cannot promise to do this by a timeline, because as a CMake noob I will probably need to learn about it first before I can understand what exactly needs to be done. With that said, will keep this in my mind and learn towards it when I have a chance.

--

Also thanks to @labath for the suggestion about using `Triple` of the `ObjectFile`. I have updated the code accordingly.

However, I am having difficulty making a test that I'm adding to pass (see `CreateInstanceReturnNonNullForMachOFile` in this patch). See my inline comments (that I will add in a second).

https://github.com/llvm/llvm-project/pull/139170