[Lldb-commits] [lldb] [NFC][lldb-dap] Avoid unnecessary copy in setBreakpoint (PR #142179)

Ebuka Ezike via lldb-commits lldb-commits at lists.llvm.org
Fri May 30 09:08:22 PDT 2025


https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142179

None

>From 68b17403353418674681a79e1d41fa57ae848db2 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Fri, 30 May 2025 16:56:18 +0100
Subject: [PATCH] [NFC][lldb-dap] remove unnecessary copy.

---
 lldb/tools/lldb-dap/Handler/SetBreakpointsRequestHandler.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lldb/tools/lldb-dap/Handler/SetBreakpointsRequestHandler.cpp b/lldb/tools/lldb-dap/Handler/SetBreakpointsRequestHandler.cpp
index 0ff88f62f8f51..5d336af740c99 100644
--- a/lldb/tools/lldb-dap/Handler/SetBreakpointsRequestHandler.cpp
+++ b/lldb/tools/lldb-dap/Handler/SetBreakpointsRequestHandler.cpp
@@ -7,8 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "DAP.h"
-#include "EventHelper.h"
-#include "JSONUtils.h"
 #include "Protocol/ProtocolRequests.h"
 #include "RequestHandler.h"
 #include <vector>
@@ -22,7 +20,7 @@ namespace lldb_dap {
 llvm::Expected<protocol::SetBreakpointsResponseBody>
 SetBreakpointsRequestHandler::Run(
     const protocol::SetBreakpointsArguments &args) const {
-  const auto response_breakpoints =
+  std::vector<protocol::Breakpoint> response_breakpoints =
       dap.SetSourceBreakpoints(args.source, args.breakpoints);
   return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)};
 }



More information about the lldb-commits mailing list