[Lldb-commits] [lldb] [LLDB] Remove redundant check in DemangledNameInfo::hasBasename (PR #142139)
Charles Zablit via lldb-commits
lldb-commits at lists.llvm.org
Fri May 30 05:42:00 PDT 2025
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/142139
This patch removes a redundant check in DemangledNameInfo::hasBasename.
Since the start and end range are unsigned, if end > start, then end is always greater than 0.
>From 738d0058769811d6f760f0a351a43ac1ab984336 Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Fri, 30 May 2025 14:40:57 +0200
Subject: [PATCH] remove redundant check in DemangledNameInfo::hasBasename
---
lldb/include/lldb/Core/DemangledNameInfo.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lldb/include/lldb/Core/DemangledNameInfo.h b/lldb/include/lldb/Core/DemangledNameInfo.h
index ab9bb3e211b66..4b5ba5e42b3b1 100644
--- a/lldb/include/lldb/Core/DemangledNameInfo.h
+++ b/lldb/include/lldb/Core/DemangledNameInfo.h
@@ -71,8 +71,7 @@ struct DemangledNameInfo {
/// Returns \c true if this object holds a valid basename range.
bool hasBasename() const {
- return BasenameRange.second > BasenameRange.first &&
- BasenameRange.second > 0;
+ return BasenameRange.second > BasenameRange.first;
}
};
More information about the lldb-commits
mailing list