[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

[David Spickett via lldb-commits]

DavidSpickett wrote:

Sorry, the above failure is a different assumption.

Our disassembly test failure is:
```
======================================================================
FAIL: test_disassemble (TestDAP_disassemble.TestDAP_disassemble)
   Tests the 'disassemble' request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/tools/lldb-dap/disassemble/TestDAP_disassemble.py", line 33, in test_disassemble
    self.assertNotIn("location", qsort_assembly, "Source location not expected.")
AssertionError: 'location' unexpectedly found in {'address': '0xFFFFF7B4BF68', 'column': 7, 'endColumn': 27, 'endLine': 66, 'instruction': '    cmp     w0, #0x0', 'instructionBytes': '1f 00 00 71', 'line': 64, 'location': {'name': 'msort.c', 'path': 'stdlib/msort.c'}} : Source location not expected.
Config=aarch64-/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang
----------------------------------------------------------------------
```
We have the libc debug symbols installed:
```
$ apt list --installed | grep libc6

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

libc6-dbg/now 2.35-0ubuntu3.9 arm64 [installed,local]
libc6-dev/now 2.35-0ubuntu3.9 arm64 [installed,local]
libc6/now 2.35-0ubuntu3.9 arm64 [installed,local]
```
Could the test work with a function marked with `nodebug` instead? https://clang.llvm.org/docs/AttributeReference.html#nodebug

(perhaps that will still have a source location)

https://github.com/llvm/llvm-project/pull/141689