[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

[John Harrison via lldb-commits]

================
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
   // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
   lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
 
+  lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+                                         uint32_t resolve_scope);
----------------
ashgti wrote:

Should we fix `SBTarget::ResolveSymbolContextForAddress` to set the `sc.target_sp` instead of introducing a new API? Without reading the source, I would have expected the SBTarget API to handle the source mapping correctly. 

https://github.com/llvm/llvm-project/pull/141426