[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

[Pavel Labath via lldb-commits]

labath wrote:

> Are these actually different on Mac? These 4 are the same on BSD to my knowledge.

I haven't checked, I guess these four might be the same on a mac, but that definitely is not the case everywhere. We're currently growing AIX support, and that one seems to have different numbers: https://www.ibm.com/docs/en/sdk-java-technology/8?topic=reference-signal-handling. According to the linux manpage, the values can vary even across linux different architectures.

> I'm not sure how Linux Signals is building actually, but it appears to have built successfully

Uses some macro trickery. We provide the symbolic constant and the value. We always use the constant value, but on linux, the macro also expands to a static_assert which checks that our constant matches what the system headers say.



> @labath I'm landing to not leave the build broken, but if you have a better solution/means of doing this let me know and I'll implement it

You should be able to get the UnixSignals object from the thread (`->GetProces()->GetUnixSignals()`). Then, instead of the symbolic constant (e.g. SIGSEGV), you compare the signal number to value from that object (`signals->GetSignalNumberFromName("SIGSEGV")`).

https://github.com/llvm/llvm-project/pull/141971