[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)
via lldb-commits
lldb-commits at lists.llvm.org
Thu May 29 09:53:19 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r HEAD~1...HEAD lldb/test/API/riscv/step/TestSoftwareStep.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- TestSoftwareStep.py 2025-05-29 16:49:47.000000 +0000
+++ TestSoftwareStep.py 2025-05-29 16:52:50.901528 +0000
@@ -11,14 +11,14 @@
class TestSoftwareStep(TestBase):
@skipIf(archs=no_match(re.compile("rv*")))
def test_cas(self):
self.build()
(target, process, cur_thread, bkpt) = lldbutil.run_to_name_breakpoint(
- self, "cas"
+ self, "cas"
)
entry_pc = cur_thread.GetFrameAtIndex(0).GetPC()
-
+
self.runCmd("thread step-inst")
self.expect(
"thread list",
substrs=["stopped", "stop reason = instruction step into"],
)
@@ -31,28 +31,33 @@
self.build(dictionary={"C_SOURCES": "branch.c", "EXE": "branch.x"})
(target, process, cur_thread, bkpt) = lldbutil.run_to_name_breakpoint(
self, "branch_cas", exe_name="branch.x"
)
entry_pc = cur_thread.GetFrameAtIndex(0).GetPC()
-
+
self.runCmd("thread step-inst")
self.expect(
"thread list",
substrs=["stopped", "stop reason = instruction step into"],
)
pc = cur_thread.GetFrameAtIndex(0).GetPC()
self.assertTrue((pc - entry_pc) > 0x10)
-
+
@skipIf(archs=no_match(re.compile("rv*")))
def test_incomplete_sequence_without_lr(self):
- self.build(dictionary={"C_SOURCES": "incomplete_sequence_without_lr.c", "EXE": "incomplete_lr.x"})
+ self.build(
+ dictionary={
+ "C_SOURCES": "incomplete_sequence_without_lr.c",
+ "EXE": "incomplete_lr.x",
+ }
+ )
(target, process, cur_thread, bkpt) = lldbutil.run_to_name_breakpoint(
self, "incomplete_cas", exe_name="incomplete_lr.x"
)
entry_pc = cur_thread.GetFrameAtIndex(0).GetPC()
-
+
self.runCmd("thread step-inst")
self.expect(
"thread list",
substrs=["stopped", "stop reason = instruction step into"],
@@ -61,21 +66,25 @@
pc = cur_thread.GetFrameAtIndex(0).GetPC()
self.assertTrue((pc - entry_pc) == 0x4)
@skipIf(archs=no_match(re.compile("rv*")))
def test_incomplete_sequence_without_sc(self):
- self.build(dictionary={"C_SOURCES": "incomplete_sequence_without_sc.c", "EXE": "incomplete_sc.x"})
+ self.build(
+ dictionary={
+ "C_SOURCES": "incomplete_sequence_without_sc.c",
+ "EXE": "incomplete_sc.x",
+ }
+ )
(target, process, cur_thread, bkpt) = lldbutil.run_to_name_breakpoint(
self, "incomplete_cas", exe_name="incomplete_sc.x"
)
entry_pc = cur_thread.GetFrameAtIndex(0).GetPC()
-
+
self.runCmd("thread step-inst")
-
+
self.expect(
"thread list",
substrs=["stopped", "stop reason = instruction step into"],
)
pc = cur_thread.GetFrameAtIndex(0).GetPC()
self.assertTrue((pc - entry_pc) == 0x4)
-
``````````
</details>
https://github.com/llvm/llvm-project/pull/127505
More information about the lldb-commits
mailing list