[Lldb-commits] [lldb] [lldb-dap] Treat empty thread names as unset (PR #141529)
via lldb-commits
lldb-commits at lists.llvm.org
Thu May 29 03:36:33 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r HEAD~1...HEAD lldb/test/API/tools/lldb-dap/threads/TestDAP_threads.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- TestDAP_threads.py 2025-05-29 10:30:33.000000 +0000
+++ TestDAP_threads.py 2025-05-29 10:36:04.955100 +0000
@@ -42,11 +42,11 @@
)
self.assertFalse(stopped_event[0]["body"]["preserveFocusHint"])
self.assertTrue(stopped_event[0]["body"]["threadCausedFocus"])
# All threads should be named Thread {index}
threads = self.dap_server.get_threads()
- self.assertTrue(all(re.match(r'^Thread \d+$', t["name"]) for t in threads))
+ self.assertTrue(all(re.match(r"^Thread \d+$", t["name"]) for t in threads))
def test_thread_format(self):
"""
Tests the support for custom thread formats.
"""
@@ -68,16 +68,15 @@
# We are stopped at the first thread
threads = self.dap_server.get_threads()
print("got thread", threads)
if self.getPlatform() == "windows":
# Windows creates a thread pool once WaitForSingleObject is called
- # by thread.join(). As we are in the thread function, we can't be
- # certain that join() has been called yet and a thread pool has
+ # by thread.join(). As we are in the thread function, we can't be
+ # certain that join() has been called yet and a thread pool has
# been created, thus we only check for the first two threads.
names = list(sorted(t["name"] for t in threads))[:2]
- self.assertEqual(names, [
- "This is thread index #1",
- "This is thread index #2"
- ])
+ self.assertEqual(
+ names, ["This is thread index #1", "This is thread index #2"]
+ )
else:
self.assertEqual(threads[0]["name"], "This is thread index #1")
self.assertEqual(threads[1]["name"], "This is thread index #2")
``````````
</details>
https://github.com/llvm/llvm-project/pull/141529
More information about the lldb-commits
mailing list