[Lldb-commits] [lldb] 3788d45 - [lldb][objc] NSError data formatter test is failing

[Jason Molenda via lldb-commits]

Author: Jason Molenda
Date: 2025-05-28T22:02:16-07:00
New Revision: 3788d459472fb28c244bad6bf010fdcbad907de7

URL: https://github.com/llvm/llvm-project/commit/3788d459472fb28c244bad6bf010fdcbad907de7
DIFF: https://github.com/llvm/llvm-project/commit/3788d459472fb28c244bad6bf010fdcbad907de7.diff

LOG: [lldb][objc] NSError data formatter test is failing
after PR 138209 stopped applying data formatters
for T** by default, and this test expects that to
work.  We'll need to figure out if we want to drop
this test, or adapt NSError/other objc formatters to
descend an extra level or two of depth.

Added: 
    

Modified: 
    lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSError.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSError.py b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSError.py
index de15e5915750b..94955661fde98 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSError.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSError.py
@@ -27,9 +27,16 @@ def nserror_data_formatter_commands(self):
             "frame variable nserror", substrs=['domain: @"Foobar" - code: -1234']
         )
 
-        self.expect(
-            "frame variable nserrorptr", substrs=['domain: @"Foobar" - code: -1234']
-        )
+        # The NSError data formatter will not apply to an NSError** after
+        # https://github.com/llvm/llvm-project/pull/138209
+        # "Add --pointer-match-depth option to type summary add command."
+        #
+        # Decide if we'll update the objc formatters to 
+        # dereference an additional depth level to keep this
+        # test working, or if we should drop the behavior.
+        #self.expect(
+        #    "frame variable nserrorptr", substrs=['domain: @"Foobar" - code: -1234']
+        #)
 
         self.expect("frame variable nserror->_userInfo", substrs=["2 key/value pairs"])