[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)
Jacob Lalonde via lldb-commits
lldb-commits at lists.llvm.org
Wed May 28 09:21:57 PDT 2025
Jlalond wrote:
> but the I find the implementation somewhat unelegant.
😎 That's certainly me!
In all seriousness, I am still drinking from the proverbial firehouse. So I appreciate the patience as I learn the codebase (even a year later).
You are correct, the checks are now unimportant because `Thread::GetSiginfoValue` will handle this for us directly, and we have a fallback clause in `CalculateStopInfo` that handled that error case. I've removed this clause. I still need to address Petr's build concern before we reapply this.
https://github.com/llvm/llvm-project/pull/141670
More information about the lldb-commits
mailing list