[Lldb-commits] [lldb] [LLDB] Pass `/std:...` before `--` on MSVC (PR #141782)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: nerix (Nerixyz)

<details>
<summary>Changes</summary>

>From https://github.com/llvm/llvm-project/pull/140761. `MsvcBuilder` passed `/std:<value>` (if specified) after `--`, so the compiler would interpret this as a file. This moves the argument before the `--`.

---
Full diff: https://github.com/llvm/llvm-project/pull/141782.diff


1 Files Affected:

- (modified) lldb/test/Shell/helper/build.py (+3-3) 


``````````diff
diff --git a/lldb/test/Shell/helper/build.py b/lldb/test/Shell/helper/build.py
index b2b8146e88c75..caaa14f90af1c 100755
--- a/lldb/test/Shell/helper/build.py
+++ b/lldb/test/Shell/helper/build.py
@@ -683,14 +683,14 @@ def _get_compilation_command(self, source, obj):
             args.append("-fms-compatibility-version=19")
         args.append("/c")
 
+        if self.std:
+            args.append("/std:" + self.std)
+
         args.append("/Fo" + obj)
         if self.toolchain_type == "clang-cl":
             args.append("--")
         args.append(source)
 
-        if self.std:
-            args.append("/std:" + self.std)
-
         return ("compiling", [source], obj, self.compile_env, args)
 
     def _get_link_command(self):

``````````

</details>


https://github.com/llvm/llvm-project/pull/141782