[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Wed May 28 06:26:02 PDT 2025


Michael137 wrote:

Getting following warning with this patch:
```
/Users/jonas/Git/llvm-worktrees/llvm-project/lldb/unittests/Core/MangledTest.cpp:417:40: warning: missing field 'PrefixRange' initializer [-Wmissing-field-initializers]
  417 |        /*.QualifiersRange=*/{158, 176} },                                                                                                             
      |                                        ^                                                                                                              
/Users/jonas/Git/llvm-worktrees/llvm-project/lldb/unittests/Core/MangledTest.cpp:423:122: warning: missing field 'PrefixRange' initializer [-Wmissing-field-initializers]
  423 |      { /*.BasenameRange=*/{6, 13}, /*.ScopeRange=*/{6, 6}, /*.ArgumentsRange=*/{ 20, 27 }, /*.QualifiersRange=*/{38, 38} },                           
      |                                                                                                                          ^                            
/Users/jonas/Git/llvm-worktrees/llvm-project/lldb/unittests/Core/MangledTest.cpp:430:38: warning: missing field 'PrefixRange' initializer [-Wmissing-field-initializers]
  430 |        /*.QualifiersRange=*/{12, 12} },                                                                                                               
      |                                      ^                                                                                                                
/Users/jonas/Git/llvm-worktrees/llvm-project/lldb/unittests/Core/MangledTest.cpp:437:38: warning: missing field 'PrefixRange' initializer [-Wmissing-field-initializers]
  437 |        /*.QualifiersRange=*/{58, 58} },                                                                                                               
      |                                      ^                                                                                                                
/Users/jonas/Git/llvm-worktrees/llvm-project/lldb/unittests/Core/MangledTest.cpp:444:38: warning: missing field 'PrefixRange' initializer [-Wmissing-field-initializers]
  444 |        /*.QualifiersRange=*/{79, 79} },                                                                                                               
      |                                      ^                                                                                                                
/Users/jonas/Git/llvm-worktrees/llvm-project/lldb/unittests/Core/MangledTest.cpp:451:40: warning: missing field 'PrefixRange' initializer [-Wmissing-field-initializers]
  451 |        /*.QualifiersRange=*/{168, 168} },                                                                                                             
      |                                        ^                                                                                                              
```
when compiling the unit-tests.

Could you add the missing initializers to the test? I think you can just add a default value so you don't need to touch every test-case


https://github.com/llvm/llvm-project/pull/140762


More information about the lldb-commits mailing list