[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

[Ely Ronnen via lldb-commits]

================
@@ -250,14 +252,16 @@ protocol::Source CreateSource(const lldb::SBFileSpec &file);
 
 /// Create a "Source" JSON object as described in the debug adapter definition.
 ///
-/// \param[in] line_entry
-///     The LLDB line table to use when populating out the "Source"
-///     object
+/// \param[in] address
+///     The address to use when populating out the "Source" object.
+///
+/// \param[in] target
+///     The target that has the address.
 ///
 /// \return
 ///     A "Source" JSON object that follows the formal JSON
 ///     definition outlined by Microsoft.
-protocol::Source CreateSource(const lldb::SBLineEntry &line_entry);
+protocol::Source CreateSource(lldb::SBAddress address, lldb::SBTarget &target);
----------------
eronnen wrote:

the `SBTarget` is not saved there, it's only used in the constructor to parse the load address

https://github.com/llvm/llvm-project/pull/141426