[Lldb-commits] [lldb] 052c704 - [lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (#141220)

[via lldb-commits]

Author: Michael Buch
Date: 2025-05-27T09:29:31+01:00
New Revision: 052c70451afb7323ef72f321f3b0b5abb024b302

URL: https://github.com/llvm/llvm-project/commit/052c70451afb7323ef72f321f3b0b5abb024b302
DIFF: https://github.com/llvm/llvm-project/commit/052c70451afb7323ef72f321f3b0b5abb024b302.diff

LOG: [lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (#141220)

`parseAndLoadModuleMapFile` returns `true` on error. This seems to have
always been an issue? This is now preventing me from fixing a different
modules related issue. So this patch checks the return value correctly.

Added: 
    

Modified: 
    lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
index eb62cb618f254..c99ed9dd0a68d 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
@@ -330,7 +330,7 @@ bool ClangModulesDeclVendorImpl::AddModule(const SourceModule &module,
       auto file = HS.lookupModuleMapFile(*dir, is_framework);
       if (!file)
         return error();
-      if (!HS.parseAndLoadModuleMapFile(*file, is_system))
+      if (HS.parseAndLoadModuleMapFile(*file, is_system))
         return error();
     }
   }