[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

[John Harrison via lldb-commits]

================
@@ -1042,16 +1042,30 @@ def request_setFunctionBreakpoints(self, names, condition=None, hitCondition=Non
         return self.send_recv(command_dict)
 
     def request_dataBreakpointInfo(
-        self, variablesReference, name, frameIndex=0, threadId=None
+        self,
+        name: str,
+        variablesReference: int = None,
+        frameIndex: int = 0,
+        bytes_: int = None,
+        asAddress: bool = None,
     ):
-        stackFrame = self.get_stackFrame(frameIndex=frameIndex, threadId=threadId)
-        if stackFrame is None:
-            return []
-        args_dict = {
-            "variablesReference": variablesReference,
-            "name": name,
-            "frameId": stackFrame["id"],
-        }
+        args_dict = {}
+        if asAddress is not None:
+            args_dict = {
+                "name": name,
+                "asAddress": asAddress,
+                "bytes": bytes_,
+            }
+        else:
+            stackFrame = self.get_stackFrame(frameIndex=frameIndex, threadId=None)
+            if stackFrame is None:
+                return []
----------------
ashgti wrote:

If we have a frameIndex and its not found, should we raise an error? I think that might be better than silently returning an empty value.

https://github.com/llvm/llvm-project/pull/141122