[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

[Kazu Hirata via lldb-commits]

kazutakahirata wrote:

> > @jansvoboda11 I've revered your PR due buildbot failures above (and my local build failures with the same error messages). I'm happy to try your revised patch to see if it build cleanly. Thanks!
> 
> I already forward-fixed both failures: [d25f95f](https://github.com/llvm/llvm-project/commit/d25f95fdbc5314f30618912e18f00ad4dd720fa0) and [b544853](https://github.com/llvm/llvm-project/commit/b544853fc335bdba6edbcde33e0c284306cd08eb).

Ah, I just realized.  Thanks!

Even if I reapply your patch, I still get:

```
llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:163:37: error: no member named 'Retain' in 'clang::DiagnosticOptions'
  163 |   static void retain(T *obj) { obj->Retain(); }
      |                                ~~~  ^
```

```
llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:164:38: error: no member named 'Release' in 'clang::DiagnosticOptions'
  164 |   static void release(T *obj) { obj->Release(); }
      |                                 ~~~  ^
```

among other things.

I'm not sure these are related to your PR.


https://github.com/llvm/llvm-project/pull/139584