[Lldb-commits] [lldb] [lldb][AArch64] Correctly invalidate svg when vg is written (PR #140875)

[David Spickett via lldb-commits]

DavidSpickett wrote:

Candidates for how it ever worked:
* Out of bounds write managing to break something else in just the right way. Then adding new extension registers meant it was invalidating registers again, probably guarded control stack registers.
* LLDB got less aggressive about re-reading registers. As you can "fix" this by re-reading svg a few times manually.
* These tests were actually flaky because of this bug and I put that down to difficulties running in simulation instead of investigating properly.

In these new patches there are some ptrace changes but nothing in lldb-server needed to change, and this mistake is so clear in hindsight, that I don't think it's a ptrace ABI difference.

https://github.com/llvm/llvm-project/pull/140875