[Lldb-commits] [lldb] [lldb][lldb-dap] show modules pane if supported by the adapter (PR #140603)

[John Harrison via lldb-commits]

================
@@ -787,7 +787,7 @@
         {
           "id": "lldb-dap.modules",
           "name": "Modules",
-          "when": "inDebugMode && debugType == 'lldb-dap'",
+          "when": "inDebugMode && debugType == 'lldb-dap' && lldb-dap.showModules",
----------------
ashgti wrote:

Can we also add a welcome view for this when its empty and still displayed? 

https://code.visualstudio.com/api/references/contribution-points#contributes.viewsWelcome covers those but a basic welcome message could be:

```json
    "viewsWelcome": [
      {
        "view": "lldb-dap.modules",
        "contents": "No modules are loaded for the active debug session."
      }
    ]
```

It should hide as soon as the tree view has contents.

https://github.com/llvm/llvm-project/pull/140603