[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)
Oliver Hunt via lldb-commits
lldb-commits at lists.llvm.org
Mon May 19 13:55:14 PDT 2025
================
@@ -99,15 +99,15 @@ class InputChunk {
// the beginning of the output section this chunk was assigned to.
int32_t outSecOff = 0;
- uint8_t sectionKind : 3;
+ uint32_t sectionKind : 3;
----------------
ojhunt wrote:
Yes, let me check whether I'm meant to be using Microsoft or MS (I may have gotten conflated with when I should use MSVC).
This does not change behavior with anything other than the MS abi. When building with the MS abi this changes the field padding to match clang/gcc/every other ABI.
The long term reason for the change is so we can enable `-Wms-bitfield-padding` without immediately overwhelming stage2 or trunk builders with the new padding warning.
Once that's enabled we can start moving to correctly typed enum bit-fields with some confidence we aren't going to regress layout under the ms abi.
https://github.com/llvm/llvm-project/pull/140493
More information about the lldb-commits
mailing list