[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Don't search for DWP files on macOS (PR #139554)

[Michael Buch via lldb-commits]

================
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap *SymbolFileDWARF::GetDebugMapSymfile() {
 
 const std::shared_ptr<SymbolFileDWARFDwo> &SymbolFileDWARF::GetDwpSymbolFile() {
   llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+    if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
----------------
Michael137 wrote:

Not sure what the resolution was re. the plugin dependencies discussion. Are we find with the current approach?

> you can't really say that SymbolFileDWARF requires ObjectFileMachO (or any other) because one can imagine a setup where someone knows they will only ever need to debug DWARF+ELF and so they want to strip out all of the other object file plugins.

Could question. If we don't want to restrict a use-case such as the one you describe, I'm happy to add a `SupportsDWP` API to ObjectFile

https://github.com/llvm/llvm-project/pull/139554