[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

[John Harrison via lldb-commits]

================
@@ -627,6 +627,60 @@ struct InstructionBreakpoint {
 bool fromJSON(const llvm::json::Value &, InstructionBreakpoint &,
               llvm::json::Path);
 
+/// Properties of a single disassembled instruction, returned by `disassemble`
+/// request.
+struct DisassembledInstruction {
+  enum PresentationHint : unsigned {
+    eSourcePresentationHintNormal,
----------------
ashgti wrote:

Should this be `eDisassembledInstructionPresentationHintNormal`? (That does feel really long...). Maybe `eInstructionPresentationHintNormal`? and same for `Invalid` below.

https://github.com/llvm/llvm-project/pull/140482