[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Thu May 15 13:15:33 PDT 2025
================
@@ -263,46 +262,61 @@ def set_global(self, name, value, id=None):
return self.dap_server.request_setVariable(2, name, str(value), id=id)
def stepIn(
- self, threadId=None, targetId=None, waitForStop=True, granularity="statement"
+ self,
+ threadId=None,
+ targetId=None,
+ waitForStop=True,
+ granularity="statement",
+ timeout=timeoutval,
):
response = self.dap_server.request_stepIn(
threadId=threadId, targetId=targetId, granularity=granularity
)
self.assertTrue(response["success"])
if waitForStop:
- return self.dap_server.wait_for_stopped()
+ return self.dap_server.wait_for_stopped(timeout)
return None
- def stepOver(self, threadId=None, waitForStop=True, granularity="statement"):
+ def stepOver(
+ self,
+ threadId=None,
+ waitForStop=True,
+ granularity="statement",
+ timeout=timeoutval,
+ ):
self.dap_server.request_next(threadId=threadId, granularity=granularity)
if waitForStop:
- return self.dap_server.wait_for_stopped()
+ return self.dap_server.wait_for_stopped(timeout)
return None
- def stepOut(self, threadId=None, waitForStop=True):
+ def stepOut(self, threadId=None, waitForStop=True, timeout=timeoutval):
self.dap_server.request_stepOut(threadId=threadId)
if waitForStop:
- return self.dap_server.wait_for_stopped()
+ return self.dap_server.wait_for_stopped(timeout)
return None
- def continue_to_next_stop(self):
- self.dap_server.request_continue()
- return self.dap_server.wait_for_stopped()
+ def verify_continue(self):
----------------
JDevlieghere wrote:
Maybe just:
```suggestion
def continue(self):
```
The "verification" seems like it's an implementation detail and raw calls to this look rather weird (I originally thought the "verification" was the stop, which it isn't).
https://github.com/llvm/llvm-project/pull/140107
More information about the lldb-commits
mailing list