[Lldb-commits] [lldb] [lldb-dap] Setup DAP for unit testing. (PR #139937)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Wed May 14 13:54:57 PDT 2025
================
@@ -1,8 +1,11 @@
add_lldb_unittest(DAPTests
+ DAPTest.cpp
+ Handler/DisconnectRequestHandlerTest.cpp
----------------
JDevlieghere wrote:
I somewhat regret the naming of the request handlers (*). Learning from our mistakes, maybe here we should just call it `Handler/DisconnectTest.cpp` to reduce the verbosity?
(*) In hindsight, I wish I called them `RequestHandlerDisconnect` instead of `DisconnectRequestHandler`, though that doesn't apply here as all the unit test files end with `Test` and I think consistency is more important.
https://github.com/llvm/llvm-project/pull/139937
More information about the lldb-commits
mailing list