[Lldb-commits] [lldb] [lldb-dap] Split lldb-dap into library and tool (NFC) (PR #139402)

[John Harrison via lldb-commits]

ashgti wrote:

Hmm after a sync, this started causing my cmake to fail to configure with:

```
$ cmake --fresh -B ~/Projects/lldb-build -G Ninja \                                
        -C ~/Projects/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \
        -DCMAKE_EXPORT_COMPILE_COMMANDS=1 \
        -DCMAKE_OSX_DEPLOYMENT_TARGET=10.12 \
        -DLLVM_ENABLE_PROJECTS="clang;lld;lldb;clang-tools-extra" \
        -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;compiler-rt;libunwind" \
        -DLLDB_USE_SYSTEM_DEBUGSERVER:BOOL=true \
        -DLIBCXX_HARDENING_MODE=none \
        -DLLVM_LIT_ARGS=-v \
        -DLIBCXX_ENABLE_SHARED:BOOL=true \
        -DCMAKE_BUILD_TYPE=Debug \
        -DLLVM_ENABLE_ASSERTIONS:BOOL=true \
        ~/Projects/llvm-project/llvm
loading initial cache file /Users/harjohn/Projects/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake

...

CMake Error at /Users/harjohn/Projects/llvm-project/lldb/cmake/modules/AddLLDB.cmake:352 (set_target_properties):
  set_target_properties Can not find target to add properties to: lldb-dap
Call Stack (most recent call first):
  /Users/harjohn/Projects/llvm-project/lldb/tools/lldb-dap/CMakeLists.txt:91 (lldb_setup_rpaths)

```

Adding `-DLLDB_BUILD_FRAMEWORK:BOOL=false` fixed this, but I think the rpath may not be correct.

https://github.com/llvm/llvm-project/pull/139402