[Lldb-commits] [lldb] [lldb] Fix term settings completion tests (PR #139447)
via lldb-commits
lldb-commits at lists.llvm.org
Sun May 11 05:31:52 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Emmanuel Ferdman (emmanuel-ferdman)
<details>
<summary>Changes</summary>
# PR Summary
Small PR - Several test functions for `term-width/height` completions had identical names, causing silent overriding. This gives them distinct _width/_height suffixes to ensure all tests run.
---
Full diff: https://github.com/llvm/llvm-project/pull/139447.diff
1 Files Affected:
- (modified) lldb/test/API/functionalities/completion/TestCompletion.py (+6-6)
``````````diff
diff --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
index bf043c795fac6..e7c53729f2090 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -334,22 +334,22 @@ def test_settings_replace_target_ru(self):
"settings replace target.ru", "settings replace target.run-args"
)
- def test_settings_show_term(self):
+ def test_settings_show_term_width(self):
self.complete_from_to("settings show term-w", "settings show term-width")
- def test_settings_list_term(self):
+ def test_settings_list_term_width(self):
self.complete_from_to("settings list term-w", "settings list term-width")
- def test_settings_show_term(self):
+ def test_settings_show_term_height(self):
self.complete_from_to("settings show term-h", "settings show term-height")
- def test_settings_list_term(self):
+ def test_settings_list_term_height(self):
self.complete_from_to("settings list term-h", "settings list term-height")
- def test_settings_remove_term(self):
+ def test_settings_remove_term_width(self):
self.complete_from_to("settings remove term-w", "settings remove term-width")
- def test_settings_remove_term(self):
+ def test_settings_remove_term_height(self):
self.complete_from_to("settings remove term-h", "settings remove term-height")
def test_settings_s(self):
``````````
</details>
https://github.com/llvm/llvm-project/pull/139447
More information about the lldb-commits
mailing list