[Lldb-commits] [lldb] [lldb] Fix term settings completion tests (PR #139447)

Emmanuel Ferdman via lldb-commits lldb-commits at lists.llvm.org
Sun May 11 05:31:10 PDT 2025


https://github.com/emmanuel-ferdman created https://github.com/llvm/llvm-project/pull/139447

# PR Summary
Small PR - Several test functions for `term-width/height` completions had identical names, causing silent overriding. This gives them distinct _width/_height suffixes to ensure all tests run.

>From f11437930874cd55b80b3f486c1dc6c19afeee9b Mon Sep 17 00:00:00 2001
From: Emmanuel Ferdman <emmanuelferdman at gmail.com>
Date: Sun, 11 May 2025 05:30:16 -0700
Subject: [PATCH] [lldb] Fix term settings completion tests

Signed-off-by: Emmanuel Ferdman <emmanuelferdman at gmail.com>
---
 .../API/functionalities/completion/TestCompletion.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
index bf043c795fac6..e7c53729f2090 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -334,22 +334,22 @@ def test_settings_replace_target_ru(self):
             "settings replace target.ru", "settings replace target.run-args"
         )
 
-    def test_settings_show_term(self):
+    def test_settings_show_term_width(self):
         self.complete_from_to("settings show term-w", "settings show term-width")
 
-    def test_settings_list_term(self):
+    def test_settings_list_term_width(self):
         self.complete_from_to("settings list term-w", "settings list term-width")
 
-    def test_settings_show_term(self):
+    def test_settings_show_term_height(self):
         self.complete_from_to("settings show term-h", "settings show term-height")
 
-    def test_settings_list_term(self):
+    def test_settings_list_term_height(self):
         self.complete_from_to("settings list term-h", "settings list term-height")
 
-    def test_settings_remove_term(self):
+    def test_settings_remove_term_width(self):
         self.complete_from_to("settings remove term-w", "settings remove term-width")
 
-    def test_settings_remove_term(self):
+    def test_settings_remove_term_height(self):
         self.complete_from_to("settings remove term-h", "settings remove term-height")
 
     def test_settings_s(self):



More information about the lldb-commits mailing list