[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Fri May 9 17:05:14 PDT 2025
https://github.com/JDevlieghere requested changes to this pull request.
I like the feautre but I think this PR can be a lot simpler:
1. I don't think you need any of the changes to `Stream` or `SBStream`. You already have to get the setting from the debugger, so just check if it has colors enabled and write the prefix (and fixed suffix) if colors are enabled.
2. I think we had settled on adding a new setting for highlighting "disabled things", with breakpoints being just one example of that. The setting should be generic, something like `disable-ansi-prefix` (*). I'm find with omitting the suffix and always issuing a clear. I can't think of a reason anyone would ever want to change that.
(*) I would prefer to call the setting`disable-format`, but then it should go through FormatEntity which is definitely overkill. I think given the existing settings, `disable-ansi-prefix` is the most consistent.
https://github.com/llvm/llvm-project/pull/91404
More information about the lldb-commits
mailing list