[Lldb-commits] [lldb] [lldb-dap] Improving tests logging to understand CI failures. (PR #139311)
via lldb-commits
lldb-commits at lists.llvm.org
Fri May 9 12:01:42 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py lldb/test/API/tools/lldb-dap/console/TestDAP_console.py lldb/test/API/tools/lldb-dap/io/TestDAP_io.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py 2025-05-09 18:58:35.000000 +0000
+++ packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py 2025-05-09 19:01:13.215268 +0000
@@ -1304,26 +1304,27 @@
super(DebugAdapterServer, self).terminate()
if self.process is not None:
process = self.process
self.process = None
try:
- # When we close stdin it should signal the lldb-dap that no
+ # When we close stdin it should signal the lldb-dap that no
# new messages will arrive and it should shutdown on its own.
process.stdin.close()
process.wait(timeout=20)
except subprocess.TimeoutExpired:
process.kill()
process.wait()
if process.returncode != 0:
raise DebugAdapterProcessError(process.returncode)
-class DebugAdapterError(Exception): pass
+class DebugAdapterError(Exception):
+ pass
+
class DebugAdapterProcessError(DebugAdapterError):
- """Raised when the lldb-dap process exits with a non-zero exit status.
- """
+ """Raised when the lldb-dap process exits with a non-zero exit status."""
def __init__(self, returncode):
self.returncode = returncode
def __str__(self):
--- test/API/tools/lldb-dap/console/TestDAP_console.py 2025-05-09 18:58:35.000000 +0000
+++ test/API/tools/lldb-dap/console/TestDAP_console.py 2025-05-09 19:01:13.291647 +0000
@@ -174,11 +174,13 @@
self.yaml2obj("minidump.yaml", core)
self.dap_server.request_evaluate(
f"target create --core {core}", context="repl"
)
- diag_message = self.collect_important(timeout_secs=self.timeoutval, pattern="minidump file")
+ diag_message = self.collect_important(
+ timeout_secs=self.timeoutval, pattern="minidump file"
+ )
self.assertIn(
"warning: unable to retrieve process ID from minidump file",
diag_message,
"diagnostic found in important output",
``````````
</details>
https://github.com/llvm/llvm-project/pull/139311
More information about the lldb-commits
mailing list