[Lldb-commits] [lldb] bbafa52 - [lldb] Fix asan failure in MinidumpFileBuilder

[Felipe de Azevedo Piovezan via lldb-commits]

Author: Felipe de Azevedo Piovezan
Date: 2025-05-08T07:27:09-07:00
New Revision: bbafa5214e8d5d5daf7cf428780500b13a7d6cbb

URL: https://github.com/llvm/llvm-project/commit/bbafa5214e8d5d5daf7cf428780500b13a7d6cbb
DIFF: https://github.com/llvm/llvm-project/commit/bbafa5214e8d5d5daf7cf428780500b13a7d6cbb.diff

LOG: [lldb] Fix asan failure in MinidumpFileBuilder

As per comment in https://github.com/llvm/llvm-project/pull/138698#issuecomment-2860369432

Added: 
    

Modified: 
    lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
index d2ca5b26c9ec9..2818d31eb2301 100644
--- a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
+++ b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
@@ -718,7 +718,7 @@ Status MinidumpFileBuilder::AddExceptions() {
     // We have 120 bytes to work with and it's unlikely description will
     // overflow, but we gotta check.
     memcpy(&exp_record.ExceptionInformation, description.c_str(),
-           std::max(description.size(), Exception::MaxParameterBytes));
+           std::min(description.size(), Exception::MaxParameterBytes));
     exp_record.UnusedAlignment = static_cast<llvm::support::ulittle32_t>(0);
     ExceptionStream exp_stream;
     exp_stream.ThreadId =