[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (reland) (PR #138981)

[David Spickett via lldb-commits]

DavidSpickett wrote:

A few tests still failing on Windows - https://lab.llvm.org/buildbot/#/builders/141/builds/8523
```
    ********************
    Unresolved Tests (1):
      lldb-api :: tools/lldb-dap/send-event/TestDAP_sendEvent.py
    ********************
    Failed Tests (2):
      lldb-api :: tools/lldb-dap/launch/TestDAP_launch.py
      lldb-api :: tools/lldb-dap/stackTrace/TestDAP_stackTrace.py
```
```
FAIL: test_version (TestDAP_launch.TestDAP_launch.test_version)

    Tests that "initialize" response contains the "version" string the same 

----------------------------------------------------------------------

========= END =========

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\tools\lldb-dap\launch\TestDAP_launch.py", line 562, in test_version

    self.continue_to_breakpoints(breakpoint_ids)

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\tools\lldb-dap\lldbdap_testcase.py", line 294, in continue_to_breakpoints

    self.verify_breakpoint_hit(breakpoint_ids)

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\tools\lldb-dap\lldbdap_testcase.py", line 113, in verify_breakpoint_hit

    self.assertTrue(False, "breakpoint not hit")

AssertionError: False is not true : breakpoint not hit
```
Looks like your previous theory, does the test need updating somehow?
```
ERROR: test_send_internal_event (TestDAP_sendEvent.TestDAP_sendEvent.test_send_internal_event)

   Test sending an internal event produces an error.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\tools\lldb-dap\send-event\TestDAP_sendEvent.py", line 62, in test_send_internal_event

    resp["body"]["result"],

    ~~~~^^^^^^^^

TypeError: list indices must be integers or slices, not str

Config=aarch64-C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe
```
Seems like it was expecting one kind of response, but got a different one.
```
======================================================================

FAIL: test_StackFrameFormat (TestDAP_stackTrace.TestDAP_stackTrace.test_StackFrameFormat)

   Test the StackFrameFormat.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\tools\lldb-dap\stackTrace\TestDAP_stackTrace.py", line 229, in test_StackFrameFormat

    frame = self.get_stackFrames(format={"parameters": True})[0]

            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\tools\lldb-dap\lldbdap_testcase.py", line 194, in get_stackFrames

    (stackFrames, totalFrames) = self.get_stackFrames_and_totalFramesCount(

                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\tools\lldb-dap\lldbdap_testcase.py", line 182, in get_stackFrames_and_totalFramesCount

    totalFrames = self.get_dict_value(response, ["body", "totalFrames"])

                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\tools\lldb-dap\lldbdap_testcase.py", line 164, in get_dict_value

    self.assertTrue(

AssertionError: False is not true : key "totalFrames" from key_path "['body', 'totalFrames']" not in "{'body': {'stackFrames': []}, 'command': 'stackTrace', 'request_seq': 7, 'seq': 0, 'success': True, 'type': 'response'}"

Config=aarch64-C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe
```
Again could be what you said, if the program never stopped that explains why there are no stack frames here.

https://github.com/llvm/llvm-project/pull/138981