[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

[Dhruv Srivastava via lldb-commits]

================
@@ -190,8 +190,83 @@ void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
 
 bool ObjectFileXCOFF::IsStripped() { return false; }
 
-void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {}
-
+void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {
+
+  if (m_sections_up)
+    return;
+  m_sections_up = std::make_unique<SectionList>();
+  ModuleSP module_sp(GetModule());
+  if (module_sp) {
+    std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
+
+    ModuleSP module_sp(GetModule());
+    for (auto sIdx = m_binary->section_begin(); sIdx != m_binary->section_end();
+         ++sIdx) {
----------------
DhruvSrivastavaX wrote:

I was trying to use it this way, to make it more friendly for both 64 bit and upcoming 32 bit support. But yes, sections64() is much better for now. Maybe we can use a global template kind of approach later for 64/32 bit?

https://github.com/llvm/llvm-project/pull/131304