[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

[Felipe de Azevedo Piovezan via lldb-commits]

felipepiovezan wrote:

Btw I think this is causing an asan failure:

https://green.lab.llvm.org/job/lldb-cmake-sanitized/1671/

```
2025-05-07T19:03:57.557Z] ==73219==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x0001070cf5b8 at pc 0x0001056051c0 bp 0x00016b0a3730 sp 0x00016b0a2ee0
[2025-05-07T19:03:57.557Z] READ of size 120 at 0x0001070cf5b8 thread T0
[2025-05-07T19:03:57.557Z]     #0 0x1056051bc in __asan_memcpy+0x394 (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x511bc)
[2025-05-07T19:03:57.557Z]     #1 0x13656e5a4 in MinidumpFileBuilder::AddExceptions() MinidumpFileBuilder.cpp:714
[2025-05-07T19:03:57.557Z]     #2 0x136565688 in ObjectFileMinidump::SaveCore(std::__1::shared_ptr<lldb_private::Process> const&, lldb_private::SaveCoreOptions&, lldb_private::Status&) ObjectFileMinidump.cpp:132
[2025-05-07T19:03:57.557Z]     #3 0x1394034f4 in lldb_private::PluginManager::SaveCore(std::__1::shared_ptr<lldb_private::Process> const&, lldb_pri
...


[2025-05-07T19:03:57.558Z] Address 0x0001070cf5b8 is located in stack of thread T0 at offset 440 in frame
[2025-05-07T19:03:57.558Z]     #0 0x13656dfa4 in MinidumpFileBuilder::AddExceptions() MinidumpFileBuilder.cpp:685
[2025-05-07T19:03:57.558Z] 
[2025-05-07T19:03:57.558Z]   This frame has 10 object(s):
[2025-05-07T19:03:57.558Z]     [32, 40) 'ref.tmp.i.i'
[2025-05-07T19:03:57.558Z]     [64, 88) 'thread_list' (line 686)
[2025-05-07T19:03:57.558Z]     [128, 144) 'stop_info_sp' (line 690)
[2025-05-07T19:03:57.558Z]     [160, 192) 'ref.tmp' (line 698)
[2025-05-07T19:03:57.558Z]     [224, 240) 'reg_ctx_sp' (line 702)
[2025-05-07T19:03:57.558Z]     [256, 376) 'exp_record.sroa.10' (line 703)
[2025-05-07T19:03:57.558Z]     [416, 440) 'description' (line 711)
[2025-05-07T19:03:57.558Z]     [480, 648) 'exp_stream' (line 717) <== Memory access at offset 440 partially underflows this variable
[2025-05-07T19:03:57.558Z]     [720, 728) 'Iter' (line 722)
[2025-05-07T19:03:57.558Z]     [752, 760) 'ref.tmp151' (line 722)
[2025-05-07T19:03:57.558Z] HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
[2025-05-07T19:03:57.558Z]       (longjmp and C++ exceptions *are* supported)
[2025-05-07T19:03:57.558Z] SUMMARY: AddressSanitizer: stack-buffer-overflow (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x511bc) in __asan_memcpy+0x394
[2025-05-07T19:03:57.558Z] Shadow bytes around the buggy address:
[2025-05-07T19:03:57.558Z]   0x0001070cf300: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
[2025-05-07T19:03:57.558Z]   0x0001070cf380: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
[2025-05-07T19:03:57.558Z]   0x0001070cf400: f1 f1 f1 f1 f8 f2 f2 f2 00 00 00 f2 f2 f2 f2 f2
[2025-05-07T19:03:57.558Z]   0x0001070cf480: 00 00 f2 f2 f8 f8 f8 f8 f2 f2 f2 f2 00 00 f2 f2
[2025-05-07T19:03:57.558Z]   0x0001070cf500: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f2
[2025-05-07T19:03:57.558Z] =>0x0001070cf580: f2 f2 f2 f2 00 00 00[f2]f2 f2 f2 f2 f8 f8 f8 f8
[2025-05-07T19:03:57.558Z]   0x0001070cf600: f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8 f8
[2025-05-07T19:03:57.558Z]   0x0001070cf680: f8 f2 f2 f2 f2 f2 f2 f2 f2 f2 f8 f2 f2 f2 f8 f3
[2025-05-07T19:03:57.558Z]   0x0001070cf700: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00
[2025-05-07T19:03:57.558Z]   0x0001070cf780: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[2025-05-07T19:03:57.558Z]   0x0001070cf800: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
[2025-05-07T19:03:57.558Z] Shadow byte legend (one shadow byte represents 8 application bytes):
```

https://github.com/llvm/llvm-project/pull/138698