[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

[John Harrison via lldb-commits]

ashgti wrote:

So, I was checking this and I see `lldb_dap::DAP::ResetDebuggerState() (/data/users/jeffreytan/llvm-sand/external/llvm-project/lldb/tools/lldb-dap/DAP.cpp:1411)` in the call stack.

That function doesn't exist in the open source version of lldb-dap. I'm not sure what its doing but it looks like its trying to join the event thread.

The `DAP::Loop` call is already cleaning up the event handler when it exits (here is the handler https://github.com/llvm/llvm-project/blob/32752913b12103431dc392242c3c808afb70bd15/lldb/tools/lldb-dap/DAP.cpp#L935-L939).

I'm not sure I have enough information on this deadlock. Is the `ResetDebuggerState` function open sourced somewhere that you could share? Or have you considered using the server mode flag to have lldb-dap manage multiple sessions?

https://github.com/llvm/llvm-project/pull/137026