[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

[Adrian Prantl via lldb-commits]

================
@@ -1028,6 +1029,23 @@ DynamicLoaderDarwin::GetStepThroughTrampolinePlan(Thread &thread,
       thread_plan_sp = std::make_shared<ThreadPlanRunToAddress>(
           thread, load_addrs, stop_others);
     }
+    // One more case we have to consider is "branch islands".  These are regular
+    // TEXT symbols but their names end in .island plus maybe a .digit suffix.
+    // They are to allow arm64 code to branch further than the size of the
+    // address slot allows.  We just need to single-instruction step in that
+    // case.
+    static const char *g_branch_island_pattern = "\\.island\\.?[0-9]*$";
----------------
adrian-prantl wrote:

This is pedantic, but maybe `"\\.island\\(.[0-9]+)?$"` would be more precise, since `foo.island.` with no number should probably not get matched?

https://github.com/llvm/llvm-project/pull/138781